Allow CW->ERC pointers to be called through wasmd precompile #1785
Conversation
codchen
force-pushed
the
tony-chen-handle-wasmd-call
branch
3 times, most recently
from
181e4fb to
ab68883
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
==========================================
- Coverage 61.64% 60.81% -0.83%
==========================================
Files 365 380 +15
Lines 26178 28021 +1843
==========================================
+ Hits 16138 17042 +904
- Misses 8967 9825 +858
- Partials 1073 1154 +81
|
codchen
force-pushed
the
tony-chen-handle-wasmd-call
branch
2 times, most recently
from
de1c3bf to
02da59a
Compare
| @@ -118,6 +118,23 @@ func (k *Keeper) CallEVM(ctx sdk.Context, from common.Address, to *common.Addres | |||
| if res.Err != nil { | |||
| vmErr = res.Err.Error() | |||
| } | |||
| existingReceipt, err := k.GetTransientReceipt(ctx, ctx.TxSum()) | |||
There was a problem hiding this comment.
is this logic related to the wasmd precompile stuff?
There was a problem hiding this comment.
yeah it's to merge with the temp receipts created in the CW->EVM hop
codchen
force-pushed
the
tony-chen-handle-wasmd-call
branch
from
02da59a to
824831c
Compare
codchen
force-pushed
the
tony-chen-handle-wasmd-call
branch
from
824831c to
4ee4fc2
Compare
* main: Add more DEX dapp tests (#1809) Add basic LST integration tests (#1814) Allow CW->ERC pointers to be called through wasmd precompile (#1785) Bump nonce even if tx fails (#1778) Fix docker setup for local cluster (#1806) Tune Configs (#1813) V5.7.5 release (#1805) Evidence Max Bytes Update (#1812) Add dApp Tests (#1802) [EVM] Tune configs (#1800) Revert dex removal (#1801) Do not charge gas for feecollector address query (#1795)
|
Apologies for being late to this. I received no communication that this was the implemented solution until now. What exactly does this protect against? I can deploy an "ERC-20 token" which can still embed a nasty payload if the "transfer" function was called with specific sender and use the address and amount params as commands for the malicious code. This solution needlessly impedes the ability for CW contracts to call the ERC-20 tokens directly without the use of a pointer with no security benefit. |
Describe your changes and provide context
For EVM transactions that call the wasmd precompile (
0x1002) directly, we want to allow the destination CW contract to be call back to some EVM contracts (e.g. ERC20) at most once (right now none is allowed). This PR leverages a new flag set onsdk.Contextto track whether a CW->EVM call is eligible for this special case. Note that this only applies to the top level - something like precompile->CW->precompile->CW is still not allowed.Testing performed to validate your change
hardhat test